non_float arrays are addrarrays
#3973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinichenko-js
force-pushed
the
dkalinichenko/separability-axis
branch
2 times, most recently
from
fce7b48 to
8a8d570
Compare
dkalinichenko-js
force-pushed
the
dkalinichenko/non-float-arrays
branch
from
3be8039 to
254299f
Compare
goldfirere
reviewed
May 16, 2025
|
I've read through this and it looks good to me... but I think I'd like further opinions before merging this potentially dangerous patch. I think it's worth some discussion. Maybe post on Slack eliciting opinions? |
goldfirere
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make arrays of
non_floatvalues always at leastaddrarrays.This seems like a both valuable and a relatively safe change. This reuses an existing optimization we have for records, variants and other non-float types, but keeps it functioning even when the element type is abstract and we only have a kind annotation.